[Tests] Normalize subtree test names and reuse message constant #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves test code maintainability by normalizing test function names and eliminating code duplication in subtree tests.
- Added a shared constant
expectedSizeFourMessageto replace repeated "expected size to be 4" assertion messages - Renamed test functions to follow Go naming conventions by removing underscores
- Replaced all hardcoded error message strings with the new constant
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
subtree_test.go.Why It Was Necessary
goconstwarning around repeated literals and simplifies future updates.Testing Performed
go test ./...golangci-lint run(fails in this environment because the configured lintersarangolint,embeddedstructfieldcheck, andwsl_v5are not recognized by the installed golangci-lint build)Impact / Risk
https://chatgpt.com/codex/tasks/task_e_68e8488070648321bc47c770e6794d68